fix: resolve 11 issues from full project review#13
Merged
Conversation
Critical: - Move NIH-plug theme setup from render callback to init callback (perf) - Fix LV2 dynamic_threshold=true making threshold port useless - Handle GlobalHotKeyManager init failure gracefully instead of panic Important: - Persist reference device selection in config across restarts - Mix (L+R)/2 for NIH-plug mono output instead of discarding right channel - Pre-create all 4 VAD instances to avoid allocation on audio thread - Log reference device enumeration errors instead of silently swallowing Suggestions: - Name audio processing threads for easier debugging - Cache eq_enabled/agc_enabled per-frame in process_updates() - Replace eprintln with log::warn in echo_cancel.rs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo checkpassescargo test— all 16 tests pass🤖 Generated with Claude Code